Don't allow PRs to latest `release-` branch

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.

Apache License 2.0

125 stars 69 forks source link

Don't allow PRs to latest `release-` branch #1585

Closed jacobbaungard closed 3 months ago

jacobbaungard commented 3 months ago

This automation checks whether a PR is merging to the latest release branch, if so the check fails.

Ensures our fast-foward logic doesn't break and main doesn't diverge.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [jacobbaungard,saswatamcode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coleenquadros commented 3 months ago

wont this block Konflux from creating PRs for 2.12? They are not set up to create against main

jacobbaungard commented 3 months ago

wont this block Konflux from creating PRs for 2.12? They are not set up to create against main

It will make a test/check fail, but PRs can still be created. I hope that when updating the PR to point to main instead the check will re-run and then pass.

Not sure what the best long-term approach for this is (i.e handling the Konflux PRs)