search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

update to deployer functions for AddOnDeploymentConfig and ClusterManagementAddOn #1592

Closed JoaoBraveCoding closed 2 months ago

JoaoBraveCoding commented 3 months ago

In https://github.com/stolostron/multicluster-observability-operator/pull/1470 we added support for deploying and configuring MCOA with the capabilities field. However, if we enabled a field in capabilities and then disabled it MCO would not reconcile the AddOnDeploymentConfig correctly due to DeepDerivative, which would return true instead of false.

JoaoBraveCoding commented 3 months ago

/retest-required

JoaoBraveCoding commented 3 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

JoaoBraveCoding commented 2 months ago

/retest-required

periklis commented 2 months ago

/retest

periklis commented 2 months ago

/retest

JoaoBraveCoding commented 2 months ago

/retest-required

periklis commented 2 months ago

/retest

periklis commented 2 months ago

/retest

JoaoBraveCoding commented 2 months ago

/retest

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, periklis, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [JoaoBraveCoding,periklis,philipgough] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
periklis commented 2 months ago

/retest