search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Fix tests for BVT testing #1598

Closed coleenquadros closed 2 months ago

coleenquadros commented 2 months ago

The BVT tests are reporting failure because some of the managed clusters are never properly imported. However, Obs tests are also not correctly detecting and skipping these unhealthy clusters, and expecting Obs add-on to be present.

https://app.travis-ci.com/github/stolostron/canary/jobs/625626340

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/retest

coleenquadros commented 2 months ago

/test test-e2e

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [coleenquadros,philipgough,subbarao-meduri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coleenquadros commented 2 months ago

/cherry-pick 2.11

openshift-cherrypick-robot commented 2 months ago

@coleenquadros: cannot checkout 2.11: error checking out "2.11": exit status 1 error: pathspec '2.11' did not match any file(s) known to git

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1598#issuecomment-2328871753): >/cherry-pick 2.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
coleenquadros commented 2 months ago

/cherry-pick release-2.11

coleenquadros commented 2 months ago

/cherry-pick release-2.10

openshift-cherrypick-robot commented 2 months ago

@coleenquadros: new pull request created: #1600

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1598#issuecomment-2328882222): >/cherry-pick release-2.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
coleenquadros commented 2 months ago

/cherry-pick release-2.9

coleenquadros commented 2 months ago

/cherry-pick release-2.8

openshift-cherrypick-robot commented 2 months ago

@coleenquadros: new pull request created: #1601

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1598#issuecomment-2328883926): >/cherry-pick release-2.10 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@coleenquadros: new pull request created: #1602

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1598#issuecomment-2328884436): >/cherry-pick release-2.9 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@coleenquadros: #1598 failed to apply on top of branch "release-2.8":

Applying: update tests to ignore clusters that dont have observability addon installed
Applying: update tests to ignore clusters that dont have observability addon installed
Applying: force add on obervability label for kind
Using index info to reconstruct a base tree...
M   cicd-scripts/setup-e2e-tests.sh
Falling back to patching base and 3-way merge...
Auto-merging cicd-scripts/setup-e2e-tests.sh
CONFLICT (content): Merge conflict in cicd-scripts/setup-e2e-tests.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 force add on obervability label for kind
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1598#issuecomment-2328884998): >/cherry-pick release-2.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.