search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Fix: sort metrics collector metrics arguments #1618

Closed thibaultmg closed 2 months ago

thibaultmg commented 2 months ago

https://issues.redhat.com/browse/ACM-13738

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thibaultmg commented 2 months ago

/cherry-pick release-2.11

openshift-cherrypick-robot commented 2 months ago

@thibaultmg: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1618#issuecomment-2345607689): >/cherry-pick release-2.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [philipgough,thibaultmg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thibaultmg commented 2 months ago

/retest

openshift-cherrypick-robot commented 2 months ago

@thibaultmg: new pull request created: #1621

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1618#issuecomment-2345607689): >/cherry-pick release-2.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.