stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Make sure local cluster is always in the managedcluster list #1637

Closed coleenquadros closed 1 month ago

coleenquadros commented 1 month ago
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [coleenquadros,subbarao-meduri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coleenquadros commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coleenquadros commented 1 month ago

/retest

coleenquadros commented 1 month ago

/retest

coleenquadros commented 1 month ago

/retest

saswatamcode commented 1 month ago

/retest

saswatamcode commented 1 month ago

/retest

coleenquadros commented 1 month ago

/retest

coleenquadros commented 1 month ago

/test test-e2e

coleenquadros commented 1 month ago

/test test-e2e

coleenquadros commented 1 month ago

/cherrypick release-2.11

coleenquadros commented 1 month ago

/cherrypick release-2.10

coleenquadros commented 1 month ago

/cherrypick release-2.11

openshift-cherrypick-robot commented 1 month ago

@coleenquadros: new pull request created: #1640

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1637#issuecomment-2382729772): >/cherrypick release-2.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
coleenquadros commented 1 month ago

/cherrypick release-2.10

openshift-cherrypick-robot commented 1 month ago

@coleenquadros: #1637 failed to apply on top of branch "release-2.10":

Applying: make sure local cluster is part of list all the time
Using index info to reconstruct a base tree...
M   operators/multiclusterobservability/controllers/placementrule/placementrule_controller.go
M   operators/multiclusterobservability/controllers/placementrule/predicate_func.go
Falling back to patching base and 3-way merge...
Auto-merging operators/multiclusterobservability/controllers/placementrule/predicate_func.go
Auto-merging operators/multiclusterobservability/controllers/placementrule/placementrule_controller.go
CONFLICT (content): Merge conflict in operators/multiclusterobservability/controllers/placementrule/placementrule_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make sure local cluster is part of list all the time
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1637#issuecomment-2382743116): >/cherrypick release-2.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.