search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

[ACM-14487] quote json variable so $variables are not expanded during shell echo #1639

Closed subbarao-meduri closed 1 month ago

subbarao-meduri commented 2 months ago

Quote shell variables so strings with $variable are not expanded during shell echo

subbarao-meduri commented 2 months ago

@saswatamcode here is how I verified the script works:

  1. imported json provided in the defect
  2. ran script to generate configmap yaml
  3. slightly changed the name of dashboard and applied configmap
  4. verified the dashboard loaded with the new name in grafana-dev
saswatamcode commented 2 months ago

/retest

subbarao-meduri commented 2 months ago

/retest-required

shane-snyder commented 2 months ago

Just passing along, that I originally reported this issue and it seems to have fixed the behavior for me.

coleenquadros commented 2 months ago

/retest

jacobbaungard commented 1 month ago

/retest

jacobbaungard commented 1 month ago

/retest

jacobbaungard commented 1 month ago

/test pr-image-mirror-grafana-dashboard-loader

saswatamcode commented 1 month ago

/lgtm

subbarao-meduri commented 1 month ago

/retest-required

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, saswatamcode, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [jacobbaungard,saswatamcode,subbarao-meduri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment