search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

ACM-13524: Fix hypershift missing custom metrics #1647

Closed thibaultmg closed 1 month ago

thibaultmg commented 1 month ago

Metrics from hypershift are federated from the uwl in-cluster prometheus by the uwl-metrics-collector. I am adding the missing ones for the dedicated etcd and apiserver dashboards.

This PR also fixes the merge or recording rules for the uwl custom metrics.

thibaultmg commented 1 month ago

/cherrypick release-2.12

openshift-cherrypick-robot commented 1 month ago

@thibaultmg: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1647#issuecomment-2400042629): >/cherrypick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [jacobbaungard,thibaultmg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@thibaultmg: new pull request created: #1648

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1647#issuecomment-2400042629): >/cherrypick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.