search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Use multi-arch origin-oauth-proxy image #1661

Closed jacobbaungard closed 1 week ago

jacobbaungard commented 2 weeks ago

During upgrade from ACM2.11->ACM2.12 for a (currently not fully understood reason) we use the proxy image from the base templates. This seem to happen only for a short while, on later reconciles we appear get the correct image from the OCP imagestream.

The image previously set in the base template were amd64 only, causing the pods to crash on any other architecture. From rbac-query-proxy and Grafana it eventually resolves, however alertmanager uses a stateful set and gets stuck due the known Kubernetes issue described here: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#forced-rollback

Ideally we'd never want to use these images, but meanwhile this should at least ensure we don't crash and leave a unhealthy stateful set for alertmanager.

jacobbaungard commented 2 weeks ago

/cherry-pick release-2.12

openshift-cherrypick-robot commented 2 weeks ago

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1661#issuecomment-2462477127): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [jacobbaungard,thibaultmg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jacobbaungard commented 2 weeks ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

openshift-cherrypick-robot commented 1 week ago

@jacobbaungard: new pull request could not be created: failed to create pull request against stolostron/multicluster-observability-operator#release-2.12 from head openshift-cherrypick-robot:cherry-pick-1661-to-release-2.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between stolostron:release-2.12 and openshift-cherrypick-robot:cherry-pick-1661-to-release-2.12"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1661#issuecomment-2462477127): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.