fix status update and cm predicate

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.

Apache License 2.0

125 stars 69 forks source link

fix status update and cm predicate #1664

Closed thibaultmg closed 16 hours ago

thibaultmg commented 2 weeks ago

This PR:

Introduces a new predicate for the configmap, only triggering reconciles when the data changes.
Only updates the status if the collector deployment was actually updated.

https://issues.redhat.com/browse/ACM-15458

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [jacobbaungard,thibaultmg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jacobbaungard commented 2 weeks ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

jacobbaungard commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

New changes are detected. LGTM label has been removed.

thibaultmg commented 1 day ago

/retest

sonarcloud[bot] commented 1 day ago

Quality Gate failed

Failed conditions
39.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

openshift-ci[bot] commented 1 day ago

@thibaultmg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/sonarcloud	8460a3fb39225dc1731614b9dce7e69060faab89	link	false	`/test sonarcloud`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).