search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Use semantic.DeepEqual for Kubernetes Obj comparison #1666

Closed coleenquadros closed 1 week ago

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [coleenquadros] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coleenquadros commented 1 week ago

/retest-required

coleenquadros commented 1 week ago

/cherry-pick release-2.12

openshift-cherrypick-robot commented 1 week ago

@coleenquadros: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1666#issuecomment-2467783734): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
coleenquadros commented 1 week ago

/retest

coleenquadros commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-unit 0d95762c8caeb98cea5b53b218b3fa9a6d02e945 link true /test test-unit
ci/prow/pr-image-mirror-endpoint-monitoring-operator 0d95762c8caeb98cea5b53b218b3fa9a6d02e945 link true /test pr-image-mirror-endpoint-monitoring-operator
ci/prow/e2e-kind 0d95762c8caeb98cea5b53b218b3fa9a6d02e945 link true /test e2e-kind
ci/prow/images 0d95762c8caeb98cea5b53b218b3fa9a6d02e945 link true /test images
ci/prow/test-e2e 0d95762c8caeb98cea5b53b218b3fa9a6d02e945 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).