search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

Bump hypershift api version to v1beta1 #1676

Closed jacobbaungard closed 1 day ago

jacobbaungard commented 6 days ago

v1alpha1 is no longer used, so we need to update to v1beta1 to avoid the metrics-collector from crashing.

Fixes: ACM-15628

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jacobbaungard commented 6 days ago

/cherry-pick main

openshift-cherrypick-robot commented 6 days ago

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1676#issuecomment-2488820698): >/cherry-pick main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jacobbaungard commented 5 days ago

/test test-e2e

jacobbaungard commented 5 days ago

/retest

jacobbaungard commented 1 day ago

/test ci/prow/pr-image-mirror-endpoint-monitoring-operator

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/release-2.12/OWNERS)~~ [jacobbaungard,philipgough] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jacobbaungard commented 1 day ago

/override ci/prow/test-e2e

Overriding as this already passed e2e once.

openshift-ci[bot] commented 1 day ago

@jacobbaungard: Overrode contexts on behalf of jacobbaungard: ci/prow/test-e2e

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1676#issuecomment-2497480531): >/override ci/prow/test-e2e > >Overriding as this already passed e2e once. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 day ago

@jacobbaungard: new pull request created: #1692

In response to [this](https://github.com/stolostron/multicluster-observability-operator/pull/1676#issuecomment-2488820698): >/cherry-pick main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.