search

stomp-js / stomp-websocket

Stomp client for Web browsers and node.js apps
https://stomp-js.github.io/stomp-websocket/
Apache License 2.0
141 stars 36 forks source link

add closeCallback to connect definition #39

Closed rulonder closed 6 years ago

rulonder commented 6 years ago

The closeCallback was missing in the typescript definitions

kum-deepak commented 6 years ago

Many thanks, I hope it fixes issue #40

I will merge and release a new version soon.

rulonder commented 6 years ago

I think there are still 2 cases not covered, I will update. if these are valid (they are not in the docs):

client.connect(login, passcode, connectCallback, HOST); client.connect(login, passcode, connectCallback, errorCallback, HOST );

kum-deepak commented 6 years ago

Many thanks, I will wait for additional commits 😄

rulonder commented 6 years ago

Hi, So far, it matches the documentation cases:

client.connect(login, passcode, connectCallback); client.connect(login, passcode, connectCallback, errorCallback); client.connect(login, passcode, connectCallback, errorCallback, closeEventCallback); client.connect(login, passcode, connectCallback, errorCallback, closeEventCallback, host);

So I think it's ready for merge. the cases in my last comment are actually not valid.

kum-deepak commented 6 years ago

Merged and released as 4.0.6. Many Thanks 👍

kum-deepak commented 6 years ago

Planning for next version of stompjs is on the way. Your participation will be really appreciated, please join at https://github.com/stomp-js/stompjs/issues/1

rulonder commented 6 years ago

Thanks Kum!! :+1: