search

stomp / stomp-spec

STOMP Protocol Specification
http://stomp.github.io/
78 stars 30 forks source link

Clarify destination in MESSAGE as the same in SEND #26

Closed chirino closed 12 years ago

LionelCons commented 12 years ago

The 1.1 spec contains:

The MESSAGE frame MUST include a destination header indicating the destination the message was sent to.

We could change it to:

The MESSAGE frame MUST include a destination header that MUST be identical to the one used in the corresponding SEND frame.

However, most brokers speak multiple protocols and there might be no "corresponding SEND frame" if the message came in via another protocol. So maybe the following is better:

The MESSAGE frame MUST include a destination header indicating the destination the message was sent to. If the message has been sent using STOMP, this destination header must be identical to the one used in the corresponding SEND frame.

Any better text to propose?

brianm commented 12 years ago

In this case we should use SHOULD not MUST. It is recommended, but there may be valid reasons not to have it be identical.

  1. SHOULD This word, or the adjective "RECOMMENDED", mean that there may exist valid reasons in particular circumstances to ignore a particular item, but the full implications must be understood and carefully weighed before choosing a different course.

LionelCons commented 12 years ago

Ok so here is what I propose.

The MESSAGE frame MUST include a destination header indicating the destination the message was sent to. If the message has been sent using STOMP, this destination header SHOULD be identical to the one used in the corresponding SEND frame.

LionelCons commented 12 years ago

hopefully fixed by commit 0149d0b