search

stompgem / stomp

A ruby gem for sending and receiving messages from a Stomp protocol compliant message queue. Includes: failover logic, ssl support.
http://stomp.github.com
Apache License 2.0
152 stars 80 forks source link

Please add tests that actually test something #102

Closed michaelklishin closed 10 years ago

michaelklishin commented 10 years ago 
@tcp_socket = mock(:tcp_socket, :close => nil, :puts => nil, :write => nil, :setsockopt => nil, :flush => true)
TCPSocket.stub!(:open).and_return @tcp_socket

gives a nice illusion of having tests. But no, for a messaging protocol client library that's not testing.

gmallard commented 10 years ago

The real tests are run by:

rake test

If you want to enhance the spec testing, feel free. Give me a PR when you have something constructive.