search

stompgem / stomp

A ruby gem for sending and receiving messages from a Stomp protocol compliant message queue. Includes: failover logic, ssl support.
http://stomp.github.com
Apache License 2.0
152 stars 80 forks source link

wishlist: convert specs to RSpec3 style #114

Closed boutil closed 8 years ago

boutil commented 9 years ago

Hi,

Would you please consider modify the syntax of the specs to make them run with RSpec3? Basically, it boils down: -replace be_true and be_false by be true and be false -replace stub! by stub, and mock by double

The following spec 'should return an empty message when receiving an empty string or nil parameter' in message_spec.rb fails with RSpec3 because empty? is a private method.

gmallard commented 8 years ago

@boutil - Hello. Hope you still have this on your radar.

I agree, the differing Rspec levels need to be addressed .... somehow.

See https://github.com/stompgem/stomp/pull/117 for a related conversation.

gmallard commented 8 years ago

Can you please try the gem code:

1) In my personal clone: https://github.com/gmallard/stomp 2) HEAD of branch 'rsvertst'

and let me know if it meets your requirements for RSpec 3.

Please provide detailed feedback if this 'fails'.

Thanks, G.

gmallard commented 8 years ago

Please try gem version 1.3.5.

Let me know if there are problems.

Please close this issue of all is OK.

Regards, Guy

gmallard commented 8 years ago

Fix: https://github.com/stompgem/stomp/commit/b3576a3c97f6b9834f801d191ae75e6609d514d9

Version: 1.3.5

Please install the latest gem.