search

stompgem / stomp

A ruby gem for sending and receiving messages from a Stomp protocol compliant message queue. Includes: failover logic, ssl support.
http://stomp.github.com
Apache License 2.0
152 stars 80 forks source link

Support Stomp+SSL Url Strings in non-failover case. #158

Open choilive opened 5 years ago

choilive commented 5 years ago

It appears using a "stomp+ssl://..." URL string is unsupported. It falls through to the default case. (Attempts to connect to localhost:61613) however it appears +ssl is supported when specifying URL strings for a failover.

Any reason why we couldnt use the same regex that parses the failover host urls for the regular url parsing?

https://github.com/stompgem/stomp/blob/2c8976a5e3c8917003e38a79a943c98fde9e3b0e/lib/client/utils.rb#L24

https://github.com/stompgem/stomp/blob/2c8976a5e3c8917003e38a79a943c98fde9e3b0e/lib/client/utils.rb#L92

gmallard commented 5 years ago

No reason that cannot be done I suppose.

Do you want to make the change and give me a PR?

gmallard commented 5 years ago

Actually the gem has never supported SSL really well except when using hashed login parameters.

I do not think this will work very well ..........

choilive commented 5 years ago

I'll try to implement it and if it works out will submit a PR.

gmallard commented 5 years ago

@choilive - any progress or thoughts on this?