search

stompgem / stomp

A ruby gem for sending and receiving messages from a Stomp protocol compliant message queue. Includes: failover logic, ssl support.
http://stomp.github.com
Apache License 2.0
152 stars 80 forks source link

Stomp::Client#unreceive should not off-by-one max_redeliveries. #68

Closed ismith closed 11 years ago

ismith commented 11 years ago

Script to demonstrate the incorrect behavior is here: https://gist.github.com/ismith/6247478

E.g., ruby file.rb 0 should print once (no retries), ruby file.rb 1 should print once (one retry), and so on, but there's an off-by-one error such that it retries once more than it should.

gmallard commented 11 years ago

Ian - I will assign you commit rights if you wish. Please let me know.

Guy

ismith commented 11 years ago

Guy - sure. What's the process ('yours' or 'the stompgem project's') for release?

gmallard commented 11 years ago

I will add you some time over the weekend, and let you know.

Process for release is ..... just release. For you to do releases I suspect you will need to be added to the list on rubygems as well. I do not have a problem with that. Your ID on rubygems is?

As far as release timings go ..... I do not believe the gem has ever had a formal policy. Even before my first commit. Just look at the history ......

Personally I release either when I have fairly major new functionality or I believe that I have something that a gem user really needs in a production environment. I tend to let smaller changes accumulate for a while.

My best advice is use your own judgment. For some production users ..... if they break, we will hear about it, I can assure you.

Guy

ismith commented 11 years ago

My rubygems id is also ismith.

Ian