Added a NullLogger, made it the default.

[ismith]

This lets us remove several instances of if @logger && @logger.respond_to?(:some_method)

(https://gist.github.com/ppaul/6540400, #9)

[rtyler]

:thumbsup:

[gmallard]

Consider doing the require of the null logger in lib/stomp.rb. One place rather than two.

stomp.gemspec appears to be updated by user edit. Use:

rake gemspec

to auto generate and validate a currently complete gemspec file.

[PaulGale]

Ian,

Some thoughts,

• Why not move Slogger.rb from the examples folder to make it a first-class part of the gem? This does not negate the need for the NullLogger. Folks can use it if they want or use their own logger.
• Make Slogger inherit from NullLogger (dog-fooding)
• Implement the Marshalling methods dump() and load() to Slogger to allow deep cloning of a parameters hash that contains a logger object.

Thanks, Paul

On Mon, Sep 23, 2013 at 6:59 PM, Guy M. Allard notifications@github.com wrote:

Consider doing the require of the null logger in lib/stomp.rb. One place rather than two.

stomp.gemspec appears to be updated by user edit. Use:

rake gemspec

to auto generate and validate a currently complete gemspec file.

— Reply to this email directly or view it on GitHub.

[ismith]

@gmallard Good call on moving the require. I regenerated the gemspec as noted.

@ppaul Moved Slogger as suggested, and made it inherit from NullLogger. Can't easily Marshal Slogger, I think, because Logger isn't marshallable - it's got IO in it. So I may have to take logger out of the params hash and just use attr_accessor, unless you have other suggestions.

[PaulGale]

This works:

class Slogger < Stomp::NullLogger
  def initialize(init_parms = nil)
    _init
    @log.info('Logger initialization complete.')
  end

  def marshal_dump
    []
  end

  def marshal_load(array)
    _init
  end

  def _init
    @log = Logger::new(STDOUT)
    @log.level = Logger::DEBUG
  end

  # ...etc
end