search

stomt / stomt-unreal-plugin

Collect feedback in-game/in-app with STOMT for Unreal Engine.
https://stomt.co/unreal
MIT License
27 stars 8 forks source link

Stomt master #3

Closed Eyesiah closed 7 years ago

philippzentner commented 7 years ago

@Eyesiah Why is it closed? I think Daniel can merge it in the next days.

Eyesiah commented 7 years ago

Unfortunately because the widget bp was changed in the master branch, and it's a binary file so it can't be merged. I'll make the same changes with the updated asset and put in another pull request tomorrow.

On Wed, Jun 14, 2017 at 9:19 PM, Philipp Zentner notifications@github.com wrote:

@Eyesiah https://github.com/eyesiah Why is it closed? I think Daniel can merge it in the next days.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-308531646, or mute the thread https://github.com/notifications/unsubscribe-auth/AAolubpdRn-8VNUILwbSC1ZzlvEgi6etks5sEDItgaJpZM4N5mWk .

daniel-schukies commented 7 years ago

When do you think is the pull request ready, because I will change the WidgetBP soon.

Von: Isaac Ashdown [mailto:notifications@github.com] Gesendet: Mittwoch, 14. Juni 2017 23:23 An: stomt/stomt-unreal-plugin stomt-unreal-plugin@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Betreff: Re: [stomt/stomt-unreal-plugin] Stomt master (#3)

Unfortunately because the widget bp was changed in the master branch, and it's a binary file so it can't be merged. I'll make the same changes with the updated asset and put in another pull request tomorrow.

On Wed, Jun 14, 2017 at 9:19 PM, Philipp Zentner <notifications@github.com mailto:notifications@github.com > wrote:

@Eyesiah https://github.com/eyesiah Why is it closed? I think Daniel can merge it in the next days.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-308531646, or mute the thread https://github.com/notifications/unsubscribe-auth/AAolubpdRn-8VNUILwbSC1ZzlvEgi6etks5sEDItgaJpZM4N5mWk .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-308562137 , or mute the thread https://github.com/notifications/unsubscribe-auth/ACHdtKhpUwPKn0XWQMuXYjBZelTxhd-Nks5sEE8qgaJpZM4N5mWk . https://github.com/notifications/beacon/ACHdtBFkoSwYCVZGi0UsvikX5RWxoal5ks5sEE8qgaJpZM4N5mWk.gif

Eyesiah commented 7 years ago

Hi Daniel, go ahead and change it, as you need, I'll probably sort it on Monday. Haven't set it up yet.

Though if you want to make the same changes, what I did is add visible, public variables for the strings that get passed to the api connection blueprint node, so that they can be configured from the owning widget. That makes it easier to merge in future changes as the user doesn't need to modify those strings in your widget BP each time.

I also changed some of the displayed strings to be FText variables, because I was getting compile warnings. That's not so high priority though, but I'd recommend it so we can get the stomt ui text localised with unreals loca system.

Hope that makes sense. We can Skype about it on Monday if you want more details. I believe you're not based in Berlin, right?

Thanks for all your help, I have to say I really like the platform, it's very useful for us. And if there was automatic log file inclusion it would be really amazing :)

Cheers, Isaac

On 17 Jun 2017 6:01 p.m., "Daniel Schukies" notifications@github.com wrote:

When do you think is the pull request ready, because I will change the WidgetBP soon.

Von: Isaac Ashdown [mailto:notifications@github.com] Gesendet: Mittwoch, 14. Juni 2017 23:23 An: stomt/stomt-unreal-plugin stomt-unreal-plugin@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Betreff: Re: [stomt/stomt-unreal-plugin] Stomt master (#3)

Unfortunately because the widget bp was changed in the master branch, and it's a binary file so it can't be merged. I'll make the same changes with the updated asset and put in another pull request tomorrow.

On Wed, Jun 14, 2017 at 9:19 PM, Philipp Zentner <notifications@github.com mailto:notifications@github.com > wrote:

@Eyesiah https://github.com/eyesiah Why is it closed? I think Daniel

can merge it in the next days.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3# issuecomment-308531646, or mute the thread https://github.com/notifications/unsubscribe-auth/AAolubpdRn- 8VNUILwbSC1ZzlvEgi6etks5sEDItgaJpZM4N5mWk .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stomt/ stomt-unreal-plugin/pull/3#issuecomment-308562137 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ ACHdtKhpUwPKn0XWQMuXYjBZelTxhd-Nks5sEE8qgaJpZM4N5mWk> . https://github.com/ notifications/beacon/ACHdtBFkoSwYCVZGi0UsvikX5RWxoa l5ks5sEE8qgaJpZM4N5mWk.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-309223609, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoluTktaM9UjTUpMfr-0So2AueUd6heks5sE_h1gaJpZM4N5mWk .

Eyesiah commented 7 years ago

Hi Daniel,

I've gone ahead and made another pull request with those changes to the BP.

Cheers, Isaac

On Sat, Jun 17, 2017 at 9:20 PM, Isaac Ashdown isaac@inbetweengames.com wrote:

Hi Daniel, go ahead and change it, as you need, I'll probably sort it on Monday. Haven't set it up yet.

Though if you want to make the same changes, what I did is add visible, public variables for the strings that get passed to the api connection blueprint node, so that they can be configured from the owning widget. That makes it easier to merge in future changes as the user doesn't need to modify those strings in your widget BP each time.

I also changed some of the displayed strings to be FText variables, because I was getting compile warnings. That's not so high priority though, but I'd recommend it so we can get the stomt ui text localised with unreals loca system.

Hope that makes sense. We can Skype about it on Monday if you want more details. I believe you're not based in Berlin, right?

Thanks for all your help, I have to say I really like the platform, it's very useful for us. And if there was automatic log file inclusion it would be really amazing :)

Cheers, Isaac

On 17 Jun 2017 6:01 p.m., "Daniel Schukies" notifications@github.com wrote:

When do you think is the pull request ready, because I will change the WidgetBP soon.

Von: Isaac Ashdown [mailto:notifications@github.com] Gesendet: Mittwoch, 14. Juni 2017 23:23 An: stomt/stomt-unreal-plugin stomt-unreal-plugin@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Betreff: Re: [stomt/stomt-unreal-plugin] Stomt master (#3)

Unfortunately because the widget bp was changed in the master branch, and it's a binary file so it can't be merged. I'll make the same changes with the updated asset and put in another pull request tomorrow.

On Wed, Jun 14, 2017 at 9:19 PM, Philipp Zentner <notifications@github.com mailto:notifications@github.com > wrote:

@Eyesiah https://github.com/eyesiah Why is it closed? I think Daniel

can merge it in the next days.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issueco mment-308531646, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAolubpdRn-8VNUILwbSC1ZzlvEgi6etks5sEDItgaJpZM4N5mWk .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-308562137> , or mute the thread https://github.com/notificati ons/unsubscribe-auth/ACHdtKhpUwPKn0XWQMuXYjBZelTxhd-Nks5sEE8qgaJpZM4N5mWk . https://github.com/notifications/beacon/ACHdtBFkoSwYCVZGi0U svikX5RWxoal5ks5sEE8qgaJpZM4N5mWk.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stomt/stomt-unreal-plugin/pull/3#issuecomment-309223609, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoluTktaM9UjTUpMfr-0So2AueUd6heks5sE_h1gaJpZM4N5mWk .