stoneatom / stonedb

StoneDB is an Open-Source MySQL HTAP and MySQL-Native DataBase for OLTP, Real-Time Analytics, a counterpart of MySQLHeatWave. (https://stonedb.io)
https://stonedb.io/
GNU General Public License v2.0
866 stars 141 forks source link

fix(tianmu): default value of the field take unaffect in load #1865 #1896

Closed Double0101 closed 1 year ago

Double0101 commented 1 year ago

Cause: in the function ParsingStrategy::ParseResult ParsingStrategy::GetOneRow field->val_str(str) cannot distinguish 0 and NULL value. Solution: Check whether field's default value is NULL.

Summary about this PR

Issue Number: close #1865

Tests Check List

Changelog

Documentation

mergify[bot] commented 1 year ago

Thanks for the contribution! I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -5.12 :warning:

Comparison is base (7d03695) 60.25% compared to head (d096d0f) 55.13%.

:exclamation: Current head d096d0f differs from pull request most recent head 52c072d. Consider uploading reports for the commit 52c072d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## stonedb-5.7-dev #1896 +/- ## =================================================== - Coverage 60.25% 55.13% -5.12% =================================================== Files 1837 2031 +194 Lines 380678 431524 +50846 =================================================== + Hits 229371 237926 +8555 - Misses 151307 193598 +42291 ``` | [Impacted Files](https://app.codecov.io/gh/stoneatom/stonedb/pull/1896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stoneatom) | Coverage Δ | | |---|---|---| | [storage/tianmu/loader/parsing\_strategy.cpp](https://app.codecov.io/gh/stoneatom/stonedb/pull/1896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stoneatom#diff-c3RvcmFnZS90aWFubXUvbG9hZGVyL3BhcnNpbmdfc3RyYXRlZ3kuY3Bw) | `70.11% <100.00%> (+0.25%)` | :arrow_up: | ... and [274 files with indirect coverage changes](https://app.codecov.io/gh/stoneatom/stonedb/pull/1896/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stoneatom)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.