bugfix(tianmu): fix aggregation result incorrect when no record #1942

stoneatom / stonedb

StoneDB is an Open-Source MySQL HTAP and MySQL-Native DataBase for OLTP, Real-Time Analytics, a counterpart of MySQLHeatWave. (https://stonedb.io)

https://stonedb.io/

GNU General Public License v2.0

866 stars 141 forks source link

bugfix(tianmu): fix aggregation result incorrect when no record #1942 #1951

Closed Double0101 closed 1 year ago

Double0101 commented 1 year ago

Cause: In the function AggregationAlgorithm::Aggregate in aggregation_algorithm.cpp, it doesn't check validity of mit before PutAggregatedValue. Solution: Check validity of mit.

Summary about this PR

Issue Number: close #1942

Tests Check List

[ ] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Changelog

[ ] New Feature
[x] Bug Fix
[ ] Performance Improvement
[ ] Build/Testing/CI/CD
[ ] Documentation
[ ] Not for changelog (changelog entry is not required)

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features

mergify[bot] commented 1 year ago

This pull request's title should follow requirements next. @Double0101 please check it :point_down:.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

feat: new feature for stonedb
fix: bug fix for stonedb
docs: changes to the documentation
workflow: ci/cd in .github
perf: Changes to improve code performance
refactor: refactoring production code, eg. renaming a variable
style: formatting, missing semi colons, etc; no production code change
test: adding missing tests, refactoring tests; no production code change
website
chore: updating grunt tasks etc; no production code change

mergify[bot] commented 1 year ago

Thanks for the contribution! I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Double0101 commented 1 year ago

[ 99%] tianmu.issue1876                         w8 [ pass ]  1217382
[100%] shutdown_report                          w0 [ pass ]       
--------------------------------------------------------------------------
The servers were restarted 22 times
Spent 2047.969 of 1299 seconds executing testcases

Completed: All 281 tests were successful.