search

stonedDiscord / serverD

attorney online custom server
GNU Affero General Public License v3.0
13 stars 8 forks source link

Advert thread connects too frequently #1

Closed oldmud0 closed 9 years ago

oldmud0 commented 9 years ago

My server just spammed

Masterserver adverter thread timed out
Masterserver adverter thread connecting...

for a couple of days until no ports were left on my server to establish a connection to the master server. Literally, Active Directory couldn't make a socket to change a user's password.

The thread should clean up after itself by closing old sockets.

Until this is fixed, I'll have to stop using serverD to prevent my server from getting trashed again.

stonedDiscord commented 9 years ago

closing the socket sometimes crashes the thread because if i close an automatically closed socket again it's a double free and I can't reliably tell whether it did or not.

oldmud0 commented 9 years ago

You should be able to free a null pointer without the thread crashing. At least that's what the C spec says. Why was *null defined?