Crashing when parsing m2s

stoneharry / WoW-Map-Asset-Parser

A tool for extracting all the used assets on a map so that only the required data needs to be packaged in a patch.

17 stars 8 forks source link

Crashing when parsing m2s #8

Open zarkeven opened 2 years ago

zarkeven commented 2 years ago

Pretty much title,

m2s: https://drive.google.com/file/d/11nx3umnhDWzlhaXXBe-gYMwPIn8g1dFE/view?usp=sharing WMOs:https://model-changing.net/files/file/183-most-wmos-cata-bfa-in-335/

mainly using the draenor, legion, and BFA WMOs

Log here log.txt

command ran: Target: F:\WoWBuildArchive\3.x\12340unpacked\WoWResourceParser.exe -e -p --adtFolder=D:\WoWBuildArchive\3\12340modded\Data\patch-4.MPQ\world\maps\thaldranath --dataFolder=F:\data "--destFolder=F:\WoWBuildArchive\3.x\12340unpacked\FIles"

zarkeven commented 2 years ago

update: got this error at the end of it, was able to screengrab it

stoneharry commented 2 years ago

It doesn't parse one of the M2's you are using correctly:

Error

I need to debug this further, it looks like a bug.

stoneharry commented 2 years ago

We tested this branch and it resolved the issue: https://github.com/stoneharry/WoW-Map-Asset-Parser/commit/ec245a671cef2c81fcdb40bc9e3c77d332aac508

In-game no missing assets could be seen, but it is possible something subtle was missed. Something is not getting parsed correctly with this test data.

I am reluctant to merge the branch because all it does is ignore the unexpected data rather than fix the issue.

stoneharry commented 1 year ago

ExperimentalRelease.zip

^ Attached experimental release compiled with changes from above

stoneharry commented 5 months ago

The latest release has the error handling and the above attachment should not be used.