stoneharry / WoW-Spell-Editor

A Spell Editor for WoW versions WOTLK 3.3.5, TBC 2.4.3, or Vanilla 1.12.1.
252 stars 115 forks source link

stancebarorder should be signed and maybe more #194

Open T1ti opened 1 year ago

T1ti commented 1 year ago

Spell editor version latest

Describe the bug Spell editor currently has it as unsigned int. In 1.12 the max used is 7 image Seems to be an actual position index and not a bit mask, about 80% the spell entries use -1 which seems to be the default.

In 2.4 and 3.3.5 the data is different, only about 65 entries use -1/4294967295, the default is 0. image

Note that WDBX has signed int as the default for almost all fields in 1.12 but has unsigned int as the default for most fields in 3.3.5, it seems that in BC or wrath blizz changed their fields and data to use unsigned as default in most cases (this one still looks like signed though). SpellEditor uses unsigned as default in the 1.12 definitions.