search

stoneharry / WoW-Spell-Editor

A Spell Editor for WoW versions WOTLK 3.3.5, TBC 2.4.3, or Vanilla 1.12.1.
252 stars 115 forks source link

StanceBarOrder not handled #209

Open howtokana opened 1 year ago

howtokana commented 1 year ago

Spell editor version 2.1.2

Describe the bug Even after editing the "Bindings_335_wotlk" and SQL, StanceBarOrder does not save upon recompiling the spell editor. It simply reverts back to it's old order.

To Reproduce Steps to reproduce the behavior:

  1. Change any StanceBarOrder in your SQL and Bindings folder. (In my case I was trying to change DK Presence order.)

Expected behavior StanceBarOrders should save without and issue on recompile.

stoneharry commented 1 year ago

Pretty sure it's loading these from the language file rather than the DBC

howtokana commented 1 year ago

Pretty sure it's loading these from the language file rather than the DBC

If I manually edit Spell.dbc they work fine but as soon as I recompile with the spell editor, it reverts it.

stoneharry commented 1 year ago

What do you mean by 'recompiling the spell editor'?

howtokana commented 1 year ago

What do you mean by 'recompiling the spell editor'?

Oh sorry it's a term I'm used to. I just export my spell.db

howtokana commented 1 year ago

export it to an .mpq file ofc

stoneharry commented 1 year ago

The StanceBarOrder column is not handled by the spell editor today, which is a gap in functionality.

However doing a export of SQL -> DBC is a 1:1 mapping and no data will be missed or changed.

You need to edit the value in the spell editor database. If you want to edit it in the DBC then you need to drop the spell editor database and reimport the new DBC.

howtokana commented 1 year ago

Ah I see, would it be possible to have the Spell Editor also handle this for future versions?