search

stoneharry / WoW-Spell-Editor

A Spell Editor for WoW versions WOTLK 3.3.5, TBC 2.4.3, or Vanilla 1.12.1.
265 stars 121 forks source link

Unsupported spell string parsing tags #59

Open Makpptfox opened 5 years ago

Makpptfox commented 5 years ago

Hi, this is a minor issue,

When you add a dividing tag ($/10;s1) for a certain effect, let's say effect1, the other effets won't be able to show the value in the "real time description" of the editor.

The dividing tag is used to show the final value of time or rage for exemple, since the input value is always bigger than the real final value the player have.

You can see it with the spell ID 17061, the $s2 is not anymore able to show the value in real time, it does the same if you change the 2 by a 3, but if you remove the dividing tag, everything works again.

stoneharry commented 5 years ago

I didn't know this type of expression existed, yeah that's not currently supported. I will have a look at adding it in a couple of weeks.

Makpptfox commented 5 years ago

@stoneharry Did some tests, and it seems like there's a couple of other expressions the editor isn't able to interpret. Do you want me to propose a pullrequest on your tag documentations with all of the tags I know that aren't in it ?

Also, I did a full research on the 30 possibles misc tags used in SPELL_AURA_FLAT_MODIFIER(107) and SPELL_AURA_PCT_MODIFIER(108) if you want it as a documentation or as a list for a possible feature on your editor. (dropdown menu with those two specific Aura selected, if it's even possible)

stoneharry commented 5 years ago

@Makpptfox Yes please! A pull request for updated doc would be brilliant. I will get around to working on this eventually, a few hours here and there.

stoneharry commented 5 years ago

I'm going to capture this additional formula using this regex: \$(\/|\*|\-|)+\d+\;\d+\w+, which would detect your example value: $/10;17057s1.

stoneharry commented 5 years ago

Added support for strings like $/10;17057s1 in 3ef37b2.

Parsed successfully

I will use this issue to also track $? not being supported, as seen in spell id 66.

stoneharry commented 4 years ago

I did a parse on all spell string descriptions and tooltips in 3.3.5a enGB and collected all the ones that failed to parse. I have attached the results to this post.

It looks like pretty much all the main tags are handled now. The ones remaining are going to be difficult to handle but maybe one day I will get round to it.

debug_unparsed_strings.txt https://pastebin.com/eSNSJvkV

stoneharry commented 3 years ago

Some work towards this done under #143