stoneman2 / LethalProgression

All-client required version of Lethal Experience. Skillpoints and more.
8 stars 16 forks source link

[BUG] Player(s) randomly level up, Manticoils involed? #62

Open Nachodde opened 7 months ago

Nachodde commented 7 months ago

Mod Version v1.3.2

Describe the bug Randomly gain lots of experience during gameplay.

Below is an excerpt from console that I believe to be relevant.

[Info : Unity Log] Kill enemy called! destroy: True [Info : Unity Log] Kill enemy called on server, destroy true [Info : Unity Log] Kill enemy called; destroy: True [Info : Unity Log] Despawn network object in kill enemy called! [Info :Lethal Progression] Enemy type: Doublewing (EnemyType) [Info :Lethal Progression] 0 players, 0 quotas, 40 initial cost, 0 person value, 0 quota value, 40 total cost. [Info :Lethal Progression] 0 players, 0 quotas, 40 initial cost, 0 person value, 0 quota value, 40 total cost.

this block of text was repeated 10-11 times in a row, followed by the player immediately gaining about 9 levels. My theory is that either another mod I was using or the base game terminated some Manticoils (called Doublewing in console) which counted as player kills and gave the player XP.

I've saved a copy of the console log with the bug if needed.

To Reproduce No idea. play the game on a map where Manticoils spawn perhaps?

Expected behavior The player should not gain experience randomly and, if this is the case, LethalProgression should not award players XP for entities killed by console.

Screenshots 20240205210821_1 Screenshot of playing on the first moon, only 170 scrap on ship, and I'm already level 24. this is just after randomly jumping from level 15. the menu also says I've made 967 credits, so it might be a item glitch instead?

I also recorded a gameplay clip from the Player's perspective: https://outplayed.tv/media/0b7mOY The player starts out with 15 levels in this clip, which itself is already high for the first moon. I am looking through the game console (not shown on recording) when the player instantly gains 9 levels.

Mod list: 2018-LC_API-3.4.5 anormaltwig-LateCompany-1.0.10 BepInEx-BepInExPack-5.4.2100 Bobbie-MetalRecharging-1.0.0 broiiler-inacraft_cosmetics_megapack-1.0.1 Electric131-OuijaBoard-1.5.3 Evaisa-HookGenPatcher-0.0.5 Evaisa-LethalThings-0.9.4 Evaisa-LethalLib-0.14.2 fivetoofive-DetailedScan-1.2.2 FlipMods-TooManyEmotes-1.8.3 fonnymunkey-SimpleHats-1.0.0 Giltong-LethalCompanyDRP-1.3.6 HomelessGinger-MaskedEnemyOverhaul-3.1.1 Jamil-Corporate_Restructure-1.0.6 Jordo-NeedyCats-1.1.1 Kittenji-Herobrine-1.2.1 KoderTeh-Boombox_Controller-1.1.9 LethalResonance-LETHALRESONANCE-3.0.6 Midge-PushCompany-1.2.0 monkes_mods-JumpDelayPatch-1.0.1 notnotnotswipez-MoreCompany-1.7.6 Ozone-BepInUtils-1.2.1 RickArg-Helmet_Cameras-2.1.5 RugbugRedfern-Skinwalkers-4.0.1 Ryokune-Physics_Items-0.1.22 SalakStudios-BetterShotgunShells-1.0.2 Silvercore-Permanent_Ladder-1.0.3 Stoneman-LethalProgression-1.3.2 tinyhoot-ShipLoot-1.0.0 EliteMasterEric-WackyCosmetics-2.0.0 x753-More_Suits-1.4.1 xCeezy-LethalEscape-0.8.5 AllToasters-SpectateEnemies-2.2.1 atg-FnafPowerOutage-1.0.1 atg-FreeJester-1.0.3 BGN-PizzaTowerEscapeMusic-2.3.0 Bibendi-AEIOUCompany-1.3.5 dslogget-PlayerMapNumbers-0.1.1 egeadam-MoreScreams-1.0.3 EladNLG-EladsHUD-1.2.1 EliteMasterEric-Coroner-1.5.3 FlipMods-MoreBlood-1.0.2 FlipMods-LetMeLookDown-1.0.1 kRYstall9-FastSwitchPlayerViewInRadar-1.3.2 nodelll-kruumys_FixResolution-1.0.0 NotAtomicBomb-TerminalApi-1.5.1 NotAtomicBomb-Terminal_Clock-1.0.5 NotAtomicBomb-Terminal_History-1.0.4 OrtonLongGaming-FreddyBracken-1.0.6 Owen3H-IntroTweaks-1.4.2 Ozone-Glow_Steps-1.1.2 Pooble-LCFartLizards-1.2.1 Pooble-LCBetterSaves-1.7.3 Rune580-LethalCompany_InputUtils-0.6.0 Renegades-FlashlightToggle-1.5.0 SoraYuki-ShowAmmoCount-1.1.0 SoulWithMae-BlackMesaInternTransferProgram-1.1.0 sunnobunno-BonkHitSFX-1.0.5 sunnobunno-LandMineFartReverb-1.0.3 sunnobunno-YippeeMod-1.2.3 Suskitech-AlwaysHearActiveWalkies-1.4.4 taffyko-NameplateTweaks-1.0.6 TwinDimensionalProductions-CoilHeadStare-1.0.4

Additional context I've played with friends in Multiplayer and we had a similar issue, except players start a fresh save file with levels. To get more data, I need to test with just LethalProgression installed, or play on a moon that does not sawn Manticoils.

TisRyno commented 5 months ago

Hey @Nachodde

This technically isn't a bug - the checks for gaining XP are for when an enemy is killed.

https://github.com/stoneman2/LethalProgression/blob/48f572c2183c53e8b3daa9a8b45c625213b7d114/LethalProgression/Patches/HudManagerPatch.cs#L58-L69

An enemy can be killed by a player, or can be "killed" by the game periodically if they get stuck or bugged out, or despawn. They all use the same method to remove the entity.

A way to reduce this problem occurring would be to use a mod such as Pathfinding Lag Fix which will attempt to stop enemies despawning due to pathfinding bugs.