search

stonemax / acme2

Another PHP client for acme protocal (version 2) implementation, used for generating letsencrypt's free ssl certificates.
MIT License
48 stars 27 forks source link

Replace infinite wait with timeouts #24

Closed halkyon closed 5 years ago

halkyon commented 6 years ago

We have seen the verification stuck forever in our testing in the case where an _acme-challenge CNAME record was incorrect, so a timeout would be good to understand what may have happened.

I checked the acmephp project and they have a similar timeout of 180 seconds on let's encrypt operations, so I think a default of 180 seconds would be sufficient. e.g. https://github.com/acmephp/acmephp/blob/d4dcd9f0093cba07b140cafd631347e4c0a18e69/src/Core/AcmeClient.php#L178

stonemax commented 5 years ago

I had add this feature in the new version(1.0.3). Thanks for your support!