search

stonemax / acme2

Another PHP client for acme protocal (version 2) implementation, used for generating letsencrypt's free ssl certificates.
MIT License
48 stars 27 forks source link

removal of 204 code #33

Closed MichalPP closed 5 years ago

MichalPP commented 5 years ago

204 code was never part of spec: https://community.letsencrypt.org/t/no-204-code-on-nonce-check/83959

after removal, dns validation works

cpu commented 5 years ago

Hi @MichalPP I think this PR is a duplicate of https://github.com/stonemax/acme2/pull/32

MichalPP commented 5 years ago

ok, I searched just issues, not PRs.

tkrynicki commented 5 years ago

Hi I wonder if it shouldn't be : if ($code != 200) { throw new NonceException("Get new nonce failed, the url is: {$newNonceUrl}"); }