search

stonewell / madedit-pv

Automatically exported from code.google.com/p/madedit-pv
1 stars 0 forks source link

compile error #7

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
On Fedora 19:

src/MadEdit/MadEdit.cpp: In function ‘int wxChCmp(const wchar_t*, const 
wxString&)’:
src/MadEdit/MadEdit.cpp:588:50: error: request for member ‘data’ in ‘(& 
wsStr)->wxString::wc_str()’, which is of non-class type ‘const wxChar* {aka 
const wchar_t*}’
     const wchar_t * wchTmpStr = (wsStr.wc_str()).data();
                                                  ^
src/MadEdit/MadEdit.cpp: In constructor ‘MadEdit::MadEdit(wxWindow*, 
wxWindowID, const wxPoint&, const wxSize&, long int)’:
src/MadEdit/MadEdit.cpp:902:17: warning: overflow in implicit constant 
conversion [-Woverflow]
     m_HexTopRow = size_t(-1);

Original issue reported on code.google.com by nerij...@gmail.com on 16 Sep 2013 at 12:03

GoogleCodeExporter commented 9 years ago 
The following patch helped:

--- src/MadEdit/MadEdit.cpp (revision 33)
+++ src/MadEdit/MadEdit.cpp (working copy)
@@ -582,11 +582,7 @@
     size_t count=wsStr.Length();
     if(!count) return 1;

-#ifdef __WXMSW__
     const wchar_t * wchTmpStr = wsStr.wc_str();
-#else
-    const wchar_t * wchTmpStr = (wsStr.wc_str()).data();
-#endif
     while(* wchStr && * wchTmpStr)
     {
         if((* wchStr) != (* wchTmpStr))

Original comment by nerij...@gmail.com on 16 Sep 2013 at 4:42

GoogleCodeExporter commented 9 years ago 
Will submit it asap

Original comment by minggang...@gmail.com on 25 Sep 2013 at 7:21

GoogleCodeExporter commented 9 years ago 
hi madedit,

I got the same make error while I am using ubuntu 13.10 64bit

src/MadEdit/MadEdit.cpp: In function ‘int wxChCmp(const wchar_t*, const 
wxString&)’:
src/MadEdit/MadEdit.cpp:588:50: error: request for member ‘data’ in ‘(& 
wsStr)->wxString::wc_str()’, which is of non-class type ‘const wxChar* {aka 
const wchar_t*}’
     const wchar_t * wchTmpStr = (wsStr.wc_str()).data();
                                                  ^
src/MadEdit/MadEdit.cpp: In constructor ‘MadEdit::MadEdit(wxWindow*, 
wxWindowID, const wxPoint&, const wxSize&, long int)’:
src/MadEdit/MadEdit.cpp:902:17: warning: overflow in implicit constant 
conversion [-Woverflow]
     m_HexTopRow = size_t(-1);
                 ^
make[2]: *** [madedit-MadEdit.o] Error 1
make[2]: Leaving directory `/home/dhousy/Downloads/madedit-pv-read-only'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dhousy/Downloads/madedit-pv-read-only'
make: *** [all] Error 2

Would you please help?

Thanks a lot
Yours Danny

Original comment by housy....@gmail.com on 21 Oct 2013 at 4:00

GoogleCodeExporter commented 9 years ago 
sorry, seems the patch works

Original comment by housy....@gmail.com on 21 Oct 2013 at 6:34