search

stonier / ecl_core

A set of tools and interfaces extending the capabilities of c++ to provide a lightweight, consistent interface with a focus for control programming.
Other
84 stars 69 forks source link

Push and Pop Formatter Broken #1

Closed stonier closed 11 years ago

stonier commented 11 years ago

From kobuki.

In my opinion, the bug is here.

follower member variable of ecl::PushAndPop is not always zero, but ecl::formatters::ByteArrayFormatter always reads buffer from zero.

stonier commented 11 years ago

Fixed in 9397c6b872cba3e894171507ef23f366fc968f3e

PushAndPop rolls over, so stencils and simple formatters on windows just doesn't work. I have a formatter that now works, but it isn't as fast because it's iterating individually over the elements since they are not guaranteed to be contiguous.