search

stonier / ecl_core

A set of tools and interfaces extending the capabilities of c++ to provide a lightweight, consistent interface with a focus for control programming.
Other
84 stars 69 forks source link

[infra] fix a bunch of problems pointed out by clang static analysis. #100

Closed stonier closed 4 years ago

stonier commented 4 years ago

There are a few changes in here:

  1. A bugfix, where a check for NULL was missed.
  2. Another bugfix, where a NULL pointer was assigned to in an error path.
  3. A bunch of dead assignments in tests. These aren't really bugs per se, but it is a good warning to have on so we remove these dead assignments.
  4. Switch the statistics counter from a float to an unsigned int64.
  5. Initialize variables in a few places to make sure we don't access uninitialized memory.
  6. Some dead code removal.

Also cleanup flops.cpp (but no functional change)

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

stonier commented 4 years ago

Note: build is failing because ecl_lite v1.0.5 hasn't made it to the build farm yet.