ecl_debug_catch fails in release

[stonier]

ecl_debug_try {
    // something
ecl_debug_catch(Exception &e) { 
    std::cout << e.what() << std::endl;
}

is broken in release mode because it doesn't know what e is.

[stonier]

This is used liberally through the ycs. Should come up with a solution for it.

[bit-pirate]

The two cases I found are related with data writes on a "ecl::Serialorftdi::Ftdi` instance and look like this:

ecl::Error PacketHandler::writeData(unsigned char *buff, unsigned long size_buff)
{
  ecl::Error error = ecl::NoError;
  if (device != NULL)
  {
    ecl_debug_try
    {
      if (device->write(buff, size_buff) == -1)
      {
        error = device->error(); // release mode and there is no exceptions, we land here.
      }
    }
    ecl_debug_catch (const ecl::StandardException &e){
      error = e.flag();
    }
  }
  else
  {
    error = ecl::NotInitialisedError;
  }
  return error;
}

I guess, it would be okay to just remove the exception handling until this gets properly fixed. Thoughts?

[stonier]

Sounds good to me - I still can't think of a way around this.

[clalancette]

@stonier For what it is worth, I just built all of ecl stuff locally in Release mode, and everything seems to work here. So we might consider closing this very old bug.

[stonier]

Oh, that's interesting. I should leave bugs open more often, let the world fix my problems :)