search

stonier / ecl_core

A set of tools and interfaces extending the capabilities of c++ to provide a lightweight, consistent interface with a focus for control programming.
Other
84 stars 69 forks source link

Make sure to ament_export_libraries. #73

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

ament_export_libraries() ends up generating a setup.sh file for each library that exports LD_LIBRARY_PATH. This is important when building in isolated mode so that downstream consumers of the libraries can find the library at runtime.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

stonier commented 6 years ago

Seems a bit redundant to export the interfaces AND the libraries. Should ament be adding LD_LIBRARY_PATH for exported interfaces? Fine with having this in here for now though, can always revert it quickly later if interfaces gets that support.

stonier commented 6 years ago

Will need a PR over in ecl_lite too.

clalancette commented 6 years ago

Seems a bit redundant to export the interfaces AND the libraries. Should ament be adding LD_LIBRARY_PATH for exported interfaces?

It's a good question, I don't know the answer. It's probably worth bringing up in ament_cmake to see what is expected to happen.

clalancette commented 6 years ago

Will need a PR over in ecl_lite too.

Oops, yeah. I had to do fixes over there too, PR upcoming.