Clang static analyzer fixes

stonier / ecl_core

A set of tools and interfaces extending the capabilities of c++ to provide a lightweight, consistent interface with a focus for control programming.

Other

84 stars 68 forks source link

Clang static analyzer fixes #98

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

A bunch of fixes pointed out by clang static analysis. I ran the tests after these changes, and they all seem to pass.

It's kind of a mish-mash of different things, which is explained further in the commit message for c968946. Let me know if you want me to split this up into different commits to make it easier to review.

stonier commented 4 years ago

Oh damn...tried to get clever and git burned me.

Touched the shared file class - looks like it might have additional problems when errors arise. That complicated logic for throwing/not throwing.
Reverted the int->float for cumulative statistics. Need a counter that can go big...with the right casting though, should keep the analyser happy.

stonier commented 4 years ago

Recreated the PR in #100. Thanks!