search

stonier / ueye_cam

A ROS nodelet and node that wraps the driver API for UEye cameras by IDS Imaging Development Systems GMBH.
Other
1 stars 2 forks source link

Incorrect dynamic parameter type changes crash the node #26

Closed stonier closed 3 years ago

stonier commented 3 years ago

Currently if you try to send it an incorrect type, it will just bomb. Should instead handle and reject the change.

$ ros2 param set ueye_cam blue_gain 0

terminate called after throwing an instance of 'rclcpp::ParameterTypeException'
[ueye-1]   what():  expected [integer] got [bool]
[ERROR] [ueye-1]: process has died [pid 30068, exit code -6, cmd 'stdbuf -o L /home/motionsim/ueye_camera_testing/lib/ueye_cam/standalone_node __params:=/tmp/launch_params__6s0cb_7'].
stonier commented 3 years ago

Need to a) catch the exception and handle it, or b) check the parameter's type (example demo).

stonier commented 3 years ago
stonier commented 3 years ago

Fixed in #32.