search

stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.16k stars 228 forks source link

🚀 Feature: Keep the original file extension for files in the uploads/shares/<sharename> folder #342

Open b-a0 opened 10 months ago

b-a0 commented 10 months ago

🔖 Feature description

Currently uploaded files are structured as follows when a share is created:

data
|-- uploads
    |-- shares
        |-- share1
            |-- long-hash1
            |-- long-hash2
            |-- long-hash3
            |-- long-hash4
            |-- archive.zip

The files under share1 have no file extension. The currently described feature would keep the long hash filename, but preserve the original file extension of the uploaded files, such that the filetree would look as follows:

data
|-- uploads
    |-- shares
        |-- share1
            |-- long-hash1.jpeg
            |-- long-hash2.JPG
            |-- long-hash3.PNG
            |-- long-hash4.JPG
            |-- archive.zip

🎤 Pitch

Using pingvin share I would like to create reverse shares to request photo uploads from a group of people (ideally in combination with the features requested in #341 and #155). I would then like to import those photos into photoprism automatically. In photoprism I can set a folder to watch (in this case that would be the pingvin /data/upload/shares folder), but it only processes files that have a valid extension.

In general it would be nice to have the uploaded files in the share folder "ready to go", such that other tools can pick them up and process them (without having to guess file extensions).

plague-doctor commented 10 months ago

It would be great if this can activate per share, and not as a default for all shares.

b-a0 commented 10 months ago

It would be great if this can activate per share, and not as a default for all shares.

Out of curiosity: what is the downside of enabling this for all shares?

plague-doctor commented 10 months ago

Privacy. I am happy with the current, scrambled file names. However, you need to have the extensions in readable form. I am happy with all shares with decrypted extensions as long as I can switch this feature this off ;-)

CrazyWolf13 commented 5 months ago

Yeah I'd also love to see this implemented, or even to fully disable FIlename Hashing at all, as I only use locally and behind auth server, that would make many processes much easier