search

stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.3k stars 237 forks source link

🐛 Bug Report: SMTP requires username/password even if the server does not require it #592

Closed alexlehm closed 1 month ago

alexlehm commented 1 month ago

👟 Reproduction steps

When I configure a SMTP that does not require authentication, e.g. when running on the same host the web server is running on, using SMTP AUTH is often not required and it would work with leaving the fields empty

👍 Expected behavior

The SMTP client should attempt to send the mail without AUTH PLAIN when the username field is empty

👎 Actual Behavior

Currently leaving the username/password fields empty leads to an error Missing credentials for "PLAIN"

📜 Logs

No response

stonith404 commented 1 month ago

I should have fixed this, but as I don't have a SMTP server without authentication I can't test it. Could you test the stonith404/pingvin-share:development image and let me know if it works?

alexlehm commented 1 month ago

Yes, it works with the development version

stonith404 commented 1 month ago

Thanks. This is now available in v1.1.0.

alexlehm commented 1 month ago

Thank you, that works as expected now