search

stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.44k stars 238 forks source link

feat(oauth): add ability to limit user IDs for Discord authentication #621

Closed COMPLEXWASTAKEN closed 1 month ago

COMPLEXWASTAKEN commented 2 months ago

hello. I have added a discord oauth id restriction to where you can set a set of ids like , and if there id is not there it will not allow them to register with discord oauth

lmk if you want anything changed or find bugs

COMPLEXWASTAKEN commented 1 month ago

oops i didnt mean to push the other to this pull request

stonith404 commented 1 month ago

No problem, but could you please remove these changes from this PR? After that it should be ready to merge :)

Regarding the email restriction, I think this would need a bit more discussion as I've mentioned, the feature doesn't really make sense for email and password authentication.

COMPLEXWASTAKEN commented 1 month ago

How do I remove them I have never did a pull request on GitHub lol

stonith404 commented 1 month ago

You have to do this in the Git CLI locally with the command git revert <commit-that-you-want-to-revert>. In this case it would be git revert 91fb162558cffd5f8685f1eb606729874ff640db. After that you can normally run git push and the commit should be reverted :)

COMPLEXWASTAKEN commented 1 month ago

done