stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.44k stars 238 forks source link

🐛 Bug Report: Clicking on done in the reverse share upload will have unexpected results #645

Closed Juliaria08 closed 1 week ago

Juliaria08 commented 1 month ago

👟 Reproduction steps

When I opened my reverse share link, uploaded something, and clicked "Done" on the Share ready section, it redirected me to the login screen, (when not logged in), and would've made it use the normal share process when logged in.

👍 Expected behavior

It should either inform the user they can't do more uploads, or redirect them to the landing page, or redirect them to the same page we're on so they can do more uploads if the link supports more uploads.

👎 Actual Behavior

It redirected me to the login screen, because it tried accessing <pingvin-share>/_next/data/<snip>/upload.json, and I got a x-nextjs-matched-path:/upload on the response (when logged in), and x-nextjs-redirect:/auth/signIn?redirect=%2Fupload when not, which causes it to go to my social login.

📜 Logs

It's likely that this is handled by the SW, as in FF, I see transferred: service-worker.

stonith404 commented 1 week ago

Fixed in v1.3.0.