search

stoodkev / SteemPlus

SteemPlus is a lightweight browser extension adding new features to your Steemit/Busy experience: - Voting slider for minnows - Possibility to filter (by tag/resteem/reputation) and sort ( by date/payout/votes) - Switch between Busy Steemit and Steemd by keyboard shortcuts - Delegation of Steem Power directly from the wallet
GNU General Public License v3.0
27 stars 32 forks source link

[2.17.5] - Edit Signature doesn’t take you to the signature edit page (settings) for your account #111

Closed tobias-g1 closed 6 years ago

tobias-g1 commented 6 years ago

Expected behavior

Upon clicking on edit signature on any page you should be redirected the settings page where you can adjust your signature.

Actual behaviour

When you click on edit signature you will not be redirected to the profile page where you can edit your signature on busy.org. Instead, the URL will be populated with https://busy.org/@undefined/settings.

How to reproduce

  1. From a fresh install download SteemPlus here

  2. Complete the on-boarding flow and sign in via steemconnect

  3. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)

  4. Go to busy.org and sign in with your account.

  5. Go to settings ensure you have “Add Signature” enabled within the settings shown in extensions pop up window, this should be enabled by default.

  6. Go to any post on the news feed.

  7. Go to the bottom of the page where you would normally write a comment, you will see a link which has the text of edit signature. Click on edit signature.

  8. You will be redirected to https://busy.org/@undefined/settings

Note:

*You can also replicate this by clicking on edit signature within the write quick post bar.

**Sometimes the edit signature doesn't appear, I would recommend refreshing until it does in the event it doesn't load.

Recording of issue

The following video shows the issue in more detail:

https://www.youtube.com/embed/QcgfPlFXkeQ

Environment

Issue Area

I believe the following is the issue area and myUsernameSignature is not being gathered correctly. $(textarea).after('<a target="_blank" href="/@' + myUsernameSignature + '/settings" class="edit-signature-post">Edit Signature</a>');

tobias-g1 commented 6 years ago

Looks like this will be resolved in #110, my bad.

tobias-g1 commented 6 years ago

The issue is present on 2.17.7

tobias-g1 commented 6 years ago

On second thought it's different steps to this, therefore this issue has no value. Will post a new issue.