stoonboii10 / garglk

Automatically exported from code.google.com/p/garglk
Other
0 stars 0 forks source link

Support for game-specific overrides setting minimum values #169

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The support for game-specific overrides in the Gargoyle settings file is nice, 
but it would be even better if it was possible to define *minimum* values for 
the overrides of the number of rows and columns of text. Example:

[ winter.z5 ]
cols          78
rows          26

The above numbers are the *minimum* numbers needed for the game to work 
properly. But if you increase the numbers, the game would still work fine. For 
a user with the default values

cols          70
rows          50

(perhaps using a rotated widescreen monitor), the game-specific overrides would 
needlessly restrict the display vertically. I therefore propose the following 
syntax:

[ winter.z5 ]
cols          78+
rows          26+

This means that the game must have at least 78 columns and 26 rows. If the user 
have defined the above ‘tallscreen monitor’ values, the actual game would 
be played using cols=78 and rows=50.

If the + values weren’t used, the settings should work as they do now. It 
*might* also be useful to support ‘-’ values, for setting the maximum row 
and column numbers, though I’m not sure any game requires this.

Original issue reported on code.google.com by k...@huftis.org on 11 Nov 2011 at 10:14

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r606.

Original comment by bcressey@gmail.com on 14 Jun 2012 at 11:10

GoogleCodeExporter commented 8 years ago
I took a slightly different approach to keep the parsing simple - please let me 
know if I missed something critical.

Original comment by bcressey@gmail.com on 14 Jun 2012 at 11:21

GoogleCodeExporter commented 8 years ago
Thanks for implementing this ‘wishlist’. I guess the settings could maybe 
also affect manual resizing of the window after the game is loaded, but this 
isn’t very important (and perhaps some people would actually *want* to easily 
be able to manually override the minrows and mincols values).

Original comment by k...@huftis.org on 9 Jul 2012 at 6:36