stopipv / isdi

ISDi (IPV Spyware Discovery) tool for Android and iOS.
MIT License
173 stars 42 forks source link

Changed default port. Added logic to start app in browser #33

Closed adilahmed31 closed 2 years ago

adilahmed31 commented 2 years ago

Resolves #19

adilahmed31 commented 2 years ago

The new port worked on macOS but the browser did not open for me either. Let's solve that before merging but otherwise the changes are good

The browser open is disabled when run in DEBUG mode, which is the default currently. Flask runs an auto reloader in debug mode, which is used to automatically relaunch the app when any code change occurs while the app is running. This causes the browser tab to open twice in debug mode so i disabled it.

If we disable this auto reload, it should work pretty smoothly. If we want to keep it, there are some hacky solutions / workarounds. Are we okay with disabling the auto reload?

grantv9 commented 2 years ago

The browser open is disabled when run in DEBUG mode, which is the default currently

I wasn't running in debug mode (aka ran TEST=0 ./isdi), and the browser didn't open for some reason.

Are we okay with disabling the auto reload?

Given that test mode is being removed in #32, I think we can ignore the situation where the browser tab is opened twice. Ultimately the port functionality works, so I'm fine approving this.

adilahmed31 commented 2 years ago

The new port works as expected. I'm not seeing the browser open either, but I'm fine approving the changes

Great! I had put in a one line flag to disable the browser open in some modes. I've removed it and it should work perfectly now irrespective of which mode it's run in