stoplightio / desktop

The Stoplight desktop app + issues repository.
https://stoplight.io
79 stars 13 forks source link

Don't silently turn off local file mode. #105

Open bradobro opened 6 years ago

bradobro commented 6 years ago

What I expect: when I'm editing and running scenarios in local file mode and editing an oas2 file it references, Stoplight Next Desktop will stay in both local file mode for both files (and the scenarios file will recognize saved changes in the oas2 file, see stoplight/prism#107).

What happens: Stoplight Next Desktop will switch off local file mode sometimes. I haven't isolated which operations cause this, but running a collection seems to do it, as does switching back and forth between oas2 and scenarios files making edits. I'm usually able to recover by reloading the app (Cmd+R), though unsaved edits are lost.

Things are working as I expect...

screenshot 2017-12-07 16 34 08

make some edits, tweak some models, run some scenarios...

screenshot 2017-12-07 16 44 19

jalleyne commented 6 years ago

+1 I'm also seeing this, I've lost a bit or work because of this as well.

krismeister commented 6 years ago

Any attention this ticket can receive would be much appreciated. Our team has lost alot of work because of this issue. The confusion with the local file, also leads to a developer to accidentally think they're editing the latest version, but its actually an outdated online version, which they then save into the local repo.

lottamus commented 6 years ago

Sorry for the delay! We've just disabled local file mode in the latest version while we fix some outstanding issues like this one.

marbemac commented 6 years ago

To followup on @lottamus's comment, the existing local file mode was a relic of our scenarios application - when it was one file per project (hence turning it on and off per file). In the recently released v4 update we removed the existing local file mode implementation to give us a bit of breathing room to work on its successor. You can of course continue to use the 3.x desktop version if local file mode is required.

We are actively working towards a more robust desktop app in v5 that opens up folders on your computer just like a regular IDE, with no switching between local/remote file mode for individual files required. We believe that this will be a far better experience, and hope you can bear with us as we make the transition!

krismeister commented 6 years ago

@marbemac We're not 100% attached to local file mode, but we do need versioning and merging, so api changes can track through the code repository lifecycle. Does the V4 hosted version help with this flow?

krismeister commented 6 years ago

For anyone else finding this thread. There is a temp fix for v3 if you use the reload option of electron.

image

Using the reload cmd-r, does correctly link up again the local file mode.

tbarn commented 5 years ago

@bradobro @krismeister good news! this is coming back in a new form. we'd love to have you beta test it. let us know if you are interested.

/cc @philsturgeon

krismeister commented 5 years ago

@tbarn that is super awesome. Right now on stoplight NEXT, we copy and paste our JSON into the code tab, so we know we have the latest Specs that are in the code branch we're working in.

We would like to beta test this.