stoplightio / json-ref-resolver

[Deprecated] Recursively resolve JSON pointers and remote authorities.
https://github.com/APIDevTools/json-schema-ref-parser
Apache License 2.0
37 stars 9 forks source link

build(deps): bump dependency-graph from 0.8.0 to 0.8.1 #149

Closed dependabot-preview[bot] closed 4 years ago

dependabot-preview[bot] commented 4 years ago

Bumps dependency-graph from 0.8.0 to 0.8.1.

Release notes *Sourced from [dependency-graph's releases](https://github.com/jriecken/dependency-graph/releases).* > ## 0.8.1 > - Ensure all nodes are included in `overallOrder` when cycles are allowed. (Fixes [#33](https://github-redirect.dependabot.com/jriecken/dependency-graph/issues/33))
Changelog *Sourced from [dependency-graph's changelog](https://github.com/jriecken/dependency-graph/blob/master/CHANGELOG.md).* > ## 0.8.1 (December 3, 2019) > > - Ensure all nodes are included in overallOrder when cycles are allowed. (Fixes [#33](https://github-redirect.dependabot.com/jriecken/dependency-graph/issues/33))
Commits - [`b7cbf67`](https://github.com/jriecken/dependency-graph/commit/b7cbf6765f1b5a1565ee0661f435803d22b6de93) Release 0.8.1 - [`8c90204`](https://github.com/jriecken/dependency-graph/commit/8c902046660a259d1afc5007b3296d8cba4bcdfd) Merge pull request [#34](https://github-redirect.dependabot.com/jriecken/dependency-graph/issues/34) from jriecken/fix-circular - [`ed6477d`](https://github.com/jriecken/dependency-graph/commit/ed6477dc19e394eb8f8d76e3a1347709d7b37507) Ensure all nodes are included in overallOrder when cycles are allowed. - [`f32dc28`](https://github.com/jriecken/dependency-graph/commit/f32dc28c02adb8d65af8aea667062bed7321e56d) Merge pull request [#32](https://github-redirect.dependabot.com/jriecken/dependency-graph/issues/32) from simondel/master - [`13f9da4`](https://github.com/jriecken/dependency-graph/commit/13f9da4b9451c9f34d753cbac4644bde14bdf590) Migrate from jasmine-node to jasmine for testing - See full diff in [compare view](https://github.com/jriecken/dependency-graph/compare/0.8.0...0.8.1)


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @P0lip.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
P0lip commented 4 years ago

@lottamus seems like dependency-graph changed something in regards to circular references. I'll take a look at it to verify whether it's a regression or an actual bugfix in case of us, but I thought you would be interested in taking a look at it as well.

lottamus commented 4 years ago

@P0lip yeah it looks like they are following circular $refs back to themselves rather than stopping at the parent. This will likely fix an issue in our Dependency graph where deep circular $refs are not connected. I suggest just updating the tests unless you think their implementation is incorrect?

P0lip commented 4 years ago

@lottamus It looks right to me. Just wanted to make sure you are fine with the change too.

P0lip commented 4 years ago

@dependabot rebase

P0lip commented 4 years ago

@dependabot merge

P0lip commented 4 years ago

@dependabot merge

stoplight-bot commented 4 years ago

:tada: This PR is included in version 3.0.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: