fix: remove ui-kit - Githubissues

stoplightio / json-schema-viewer

A JSON Schema viewer React component

Apache License 2.0

175 stars 37 forks source link

fix: remove ui-kit #149

Closed mallachari closed 3 years ago

mallachari commented 3 years ago

Needed for https://github.com/stoplightio/elements/pull/1360

Removes ui-kit dependency
Uses new markdown-viewer
Uses new sl-scripts - this is the only solution I found that made JSV work with markdown-viewer when used outside with webpack 4. More specifically create-react-app in one of elements examples was using jsv as es module which was then importing mdv from cjs module which was breaking build. Building JSV the same way as MDV with recent scripts makes it work perfectly.

billiegoose commented 3 years ago

Oh this (code) looks great! Let's yalc it into ninja/studio just to derisk it. I can do it later this evening if you want

billiegoose commented 3 years ago

Eh, it doesn't quite look right yalced into platform, but I think it's just a margins and borders.

I suppose I need to yalc https://github.com/stoplightio/elements/pull/1360 as well to get the full picture. Uno momento...

billiegoose commented 3 years ago

Ah. I can't seem to yalc elements-core into platform bc it complains Cannot find module '@stoplight/elements-core/containers/TableOfContents'

mallachari commented 3 years ago

Thanks for checking. It possibly needs some simple styling in studio due to missing ui-kit classes and mdv using different font-size. Though it should come with elements once https://github.com/stoplightio/elements/pull/1332 is merged.

stoplight-bot commented 3 years ago

:tada: This PR is included in version 4.0.0-beta.20 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stoplight-bot commented 3 years ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: