Closed klaude closed 1 year ago
I fixed the PR's subject to conform to Conventional Changelog's formatting, but can't re-run the lint job to verify. I'm afraid one of y'all may need to re-run it to verify it passes now.
Thanks!
Hi. I face an issue in downloading the image in install.sh
. I get the below error:
Error requesting. Download binary from https://github.com/stoplightio/spectral/releases/latest/download/spectral-linux-x64
while https://github.com/stoplightio/spectral/releases/latest/download/spectral-linux
is working fine.
This is the link to the doc: https://meta.stoplight.io/docs/spectral/b8391e051b7d8-installation#executable-binaries
Is there a plan to fix this issue? Is it possible to upload the binaries with arch-suffix?
Thanks!
@alireza-mht done!
@P0lip Thanks!
:tada: This PR is included in version 6.9.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:
Fixes #2189.
Checklist
Not applicable. Tests were run, and documentation was checked, but these changes don't require test or documentation changes.
Does this PR introduce a breaking change?
Release binaries for Linux, macOS, and Alpine now have their arch suffixed to their names. Prior to the change, release binaries were named:
spectral-linux
spectral-macos
spectral-alpine
They are now:
spectral-linux-x64
spectral-linux-arm64
spectral-macos-x64
spectral-macos-arm64
spectral-alpine-x64
spectral-alpine-arm64
The installation script has been updated to work with this change, but it breaks workflows for users or systems who depend on the original naming pattern.
I can copy the x64 binaries to files with their original name to prevent the BC break, but that could make the file list in the release look a little confusing.
Additional context
Unrelated to binary builds is a fix to the installation script that will prevent bugs when executing the script from a directory with a space in its name.
Thanks for checking this out! I'm open to commentary and suggestions.