stoplightio / spectral

A flexible JSON/YAML linter for creating automated style guides, with baked in support for OpenAPI (v3.1, v3.0, and v2.0), Arazzo v1.0, as well as AsyncAPI v2.x.
https://stoplight.io/spectral
Apache License 2.0
2.48k stars 233 forks source link

chore(ruleset-bundler): rollup plugin commonjs is a dev dependency #2564

Open w3nl opened 9 months ago

w3nl commented 9 months ago

Fixes #2563.

Checklist

Does this PR introduce a breaking change?

For @stoplight/spectral-ruleset-bundler it is not needed to have this as a normal dependency. Only used in a test, so not needed to set to the dependencies.

For @stoplight/spectral-cli it is used, so that package should have it as a dependency.

If indicated yes above, please describe the breaking change(s).

Remove this quote before creating the PR.

Additional context

Also fixes a Snyk issue of inflight https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 @stoplight/spectral-ruleset-bundler@1.5.2 › @rollup/plugin-commonjs@25.0.7 › glob@8.1.0 › inflight@1.0.6

brendarearden commented 2 months ago

@w3nl we are unable to review this properly until tests are passing and conflicts are resolved. Please update the PR so we can move forward with this change.

w3nl commented 2 months ago

I will check