stoprocent / noble

A Node.js BLE (Bluetooth Low Energy) central module
MIT License
10 stars 0 forks source link

Post install scripts let npm install fail #7

Closed Apollon77 closed 1 month ago

Apollon77 commented 1 month ago

see https://github.com/Apollon77/hap-controller-node/actions/runs/11073038352/job/30768679102#step:4:13

npm error code 1
npm error path /home/runner/work/hap-controller-node/hap-controller-node/node_modules/@stoprocent/noble
npm error command failed
npm error command sh -c patch-package
npm error patch-package 8.0.0
npm error Applying patches...
npm error Error: Patch file found for package docker-pull which is not present at node_modules/@vweevers/docker-pull
npm error Error: Patch file found for package docker-run which is not present at node_modules/docker-run
npm error Error: Patch file found for package prebuildify-cross which is not present at node_modules/prebuildify-cross
npm error ---
npm error patch-package finished with 3 error(s).

That more sound like patch stuff that is only relevant for your CI pipeline and should never trigger errors when used normally, or? I also saw that the first time on 1.4.2

Apollon77 commented 1 month ago

https://github.com/stoprocent/noble/commit/c2feb69551845ba451ebb8a4c591345550babe05#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R67 is causing

stoprocent commented 1 month ago

This has been fixed with 1.14.3 release

Apollon77 commented 1 month ago

verified, thank you!