Closed Peeja closed 1 month ago
Lint errors, please hold…
@alanshaw Not sure what's failing here. It should be unrelated. Are these tests a bit flaky, or did I bump something?
@alanshaw Rereview? WDYT?
Hi!
I did some investigating and it appears the build is failing for you on seed.run cause of the pluralization of HOSTED_ZONES. I added this env variable and now it's just failing on the flaky tests.
However, I'm seeing some other issues in the code as well around this pluralization and it needs a cleanup at minimum. For example the env.tpl lists HOSTED_ZONE and HOSTED_STORACHA_ZONE. And there's a reference to .HOSTED_ZONE in the filecoin stack.
Also in the integration tests if it's run locally I believe it tries to derive the api endpoint from .ApiEndpoint instead of .ApiEndpoints.
That's as far as I got -- I'm actually having an error running on my own deployment environment cause it says preact isn't defined in the lambda response when I click the email. I'm not sure if this is related to the typescript change or not, but all my integration tests fail when I attempt to validate the email. Generally, it should be possible to run npm run test-integration
successfully even locally, though I'm not 100% sure about that.
Anyway, gonna move on to actually trying to fix flaky tests but this may be the source of your issues in seed.run
I might also suggest setting HOSTED_ZONES on the fly if it's not present from HOSTED_ZONE and HOSTED_STORACHA_ZONE for maximum backward compatibility.
@hannahhoward I don't think that's it. https://github.com/storacha-network/w3infra/pull/418 is failing too. All that does is bump the TypeScript version.
@hannahhoward Also, you're right that there are references to HOSTED_ZONE
which I missed. Now that I'm looking at them, I could use some direction. I don't fully understand the Filecoin and Roundabout stacks yet; what are they doing with that URL and what should they do when there are multiple "brands" to choose from?
Notably, there's one HOSTED_ZONE
which is fine: the validate-email
function takes a HOSTED_ZONE
env var for its own hosted zone. It's instantiated for each of the zones configured.
As for reading from ApiEndpoints
…apparently I didn't push that commit. 🤦🏻♀️ It's up now. 😅
@Peeja for the filecoin and roundabout stacks, these are entirely API services with no direct interaction with the client. Honestly, they should probably all be on the storacha.network domain, but for now we can just avoid any change and use HOSTED_ZONES.split(",")[0]
Before Merge:
HOSTED_ZONES
(plural) onprod
.With
NEXT_PUBLIC_W3UP_SERVICE_URL=https://petra.up.storacha.network
in my localconsole
:Then…
And success!
Or, failure.
Note that that error message is a dummy message in the test harness, not something real. Also, I see to have bumped something that made the Stripe section always appear. Previously, staging/prod was set not to show it by not providing the right env vars. I'm not sure why that changed, and whether we want it to.
Closes https://github.com/storacha-network/project-tracking/issues/119